Fix bundle size test after webpack 5 update #10502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtisman
changed the title
⯅ @fluid-example/bundle-size-tests: +1.16 MB
Baseline commit: c32854f |
|
Is it practical to make this test fail if it's clearly not working in this way? Maybe check the bundle is valid/works, or check for a minimum size? |
scottn12
approved these changes
Jun 2, 2022
|
@CraigMacomber yeah, I was thinking about telemetry and alert would be good, but your suggestion to just failed the test is great if the size is under certain limit. Let me make a follow up PR. |
curtisman
added a commit
that referenced
this pull request
Jun 2, 2022
Follow up to PR #10502, where we broke the bundle size test. This change updates the tools to include some sanity check by processing the generated stats file and error if the asset size being tested is smaller than certain threshold (currently set at 100 bytes). Note that the build tool package will need to be published and updated in the core packages mono repo before this will take effect. Example output of the tool if the fix for #10502 is removed: ``` found bundleAnalysis for @fluid-example/bundle-size-tests @fluid-example/bundle-size-tests: asset aqueduct.js (23) is too small @fluid-example/bundle-size-tests: asset connectionState.js (23) is too small @fluid-example/bundle-size-tests: asset containerRuntime.js (23) is too small @fluid-example/bundle-size-tests: asset loader.js (23) is too small @fluid-example/bundle-size-tests: asset map.js (23) is too small @fluid-example/bundle-size-tests: asset matrix.js (23) is too small @fluid-example/bundle-size-tests: asset odspDriver.js (23) is too small @fluid-example/bundle-size-tests: asset odspPrefetchSnapshot.js (23) is too small @fluid-example/bundle-size-tests: asset sharedString.js (23) is too small Error: Found assets are too small (<100 bytes). Webpack bundle analysis is probably not correct. ```
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10186 upgraded to webpack 5, which caused the output of the bundle-size-test to be all 23 bytes with all export removed.
See #10186 (comment)
Adding
output.libraryin the webpack config fixes the issue.